Use serde(skip) instead of skip_serializing, add placeholder values #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
changed the title
Nutomic
force-pushed
the
no-skip-serializing
branch
from
30fef84
to
993968f
Compare
Nutomic
force-pushed
the
no-skip-serializing
branch
from
993968f
to
fc2b87a
Compare
|
Do we have api stability tests? |
The latter breaks lemmy_crawler as the field is not included in the Lemmy API, but is required when attempting to parse API responses. Should only use serde(skip) to avoid this problem
Nutomic
force-pushed
the
no-skip-serializing
branch
from
fc2b87a
to
02eecd2
Compare
|
@bqv Not really, but the code for lemmy-js-client is auto-generated from Lemmy source, so you will see any changes there in the git log. |
|
Dont know why Github closed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter breaks lemmy_crawler as the field is not included in the Lemmy API, but is required when attempting to parse API responses. Should only use serde(skip) to avoid this problem. I also had to add placeholder values so that deserialization works even though these mandatory fields arent being sent by Lemmy.