Added gitattributes to normalize all files to lf #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
approved these changes
Jun 28, 2023
This makes it less annoying to build on windows/mac
dessalines
approved these changes
Jun 28, 2023
|
In the past, I've always had to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to build this on Windows through Docker and WSL and I ran into the problem that the docker_update.sh was using crlf line endings. I converted it to lf no problem but it's probably better to just normalize the line endings of everything for better consistency. I'm not sure if this breaks anything in the rest of the code though, so I could edit this to only effect docker/docker_update.sh if necessary. Either way, having git normalize the file to lf makes it less annoying to build on Windows/Mac.