fix(posts): return error on invalid community name

[lgerard-pass]

This should fix #3383

Before when we get an error while listing posts on a community, because the community does not exists, we transform the Result we get into an Option, after that there is no way to recognize whether a community name was given and not found, or if no name was given at all.

To fix this, I'm simply returning the error if there is one, if not I simply wrap the value we get in an Option.

This gives a 404 error when requesting http://localhost:8536/api/v3/post/list?community_name=InvalidCommunityName with the Record not found message which from my testing is the same behavior we get if we try to follow a community that does not exists.

I'm just starting out Rust so please don't hesitate to let me know if that's not a good way to implement it.

[Nutomic]

Makes sense. You should also make the same change in list_comments.rs and search.rs.

[lgerard-pass]

Yep,
I've added these changes and I get the same error querying :

http://localhost:8536/api/v3/search?q=test&community_name=InvalidCommunity
http://localhost:8536/api/v3/comment/list?community_name=InvalidCommunity

Running these calls with a valid community returns the expected results.

[Nutomic]

Ups I just merged another PR which causes a conflict with this one, can you fix the conflicts?

[lgerard-pass]

I've rebased as you asked, I also add to update the branch a few times to keep up with main but unless another commit is merged, it should be ready for merging.

[Nutomic]

Federation tests are failing in CI but passing locally, so Im merging this manually.