Remove not needed anymore http-signature-normalization-actix dependency #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This library is actually not needed anymore in Lemmy, as HTTP signatures are entirely handled in the activitypub-federation library. So you can remove the dependency and all code that uses it. However the activitypub library still uses this dependency, so it probably has the same license issue. I moved the issue there. |
pijuszczyk
force-pushed
the
upgrade-http-signature-normalization-actix
branch
from
f3e5214
to
4b0ea08
Compare
pijuszczyk
changed the title
Nutomic
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade http-signature-normalization-actix to avoid confusion regarding the package's license and its compliance with lemmy's license - fixes LemmyNet/activitypub-federation-rust#57.