Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a person.admin index, and featured_local/community indexes. #3479

Merged
merged 1 commit into from Jul 5, 2023

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Jul 4, 2023

These turned out to make a difference. In my testing, unprimed queries went from ~ 100ms down to 30ms, and primed ones went under 10ms.

Still doesn't address #2994 , but there might not be a good way to do subquery from selects in diesel, and we might have to use the sql_query function for that one.

@dessalines dessalines requested a review from Nutomic as a code owner July 4, 2023 19:11
@phiresky
Copy link
Collaborator

phiresky commented Jul 5, 2023

Ah I see you added a person.admin index as well. I've added one in #3483 although I also filter the index by where admin to reduce index size.

@Nutomic Nutomic merged commit 657c2e3 into main Jul 5, 2023
2 checks passed
@phiresky
Copy link
Collaborator

phiresky commented Jul 5, 2023

@Nutomic ah the create index idx_person_admin on person (admin); index is duplicate now, you should remove one of them (probably the one from this PR because it uses more space)

Edit: i see you commented there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants