Shrink capacity in RateLimitStorage::remove_older_than
#3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci ran out of space |
|
Ran out of space again |
Nutomic
reviewed
Jul 10, 2023
| // `shrink_to_fit` is not used because it would cause the capacity to be doubled when more capacity is needed | ||
| if let Some(min_capacity) = map.len().checked_mul(2) { | ||
| map.shrink_to(min_capacity); | ||
| } |
There was a problem hiding this comment.
So shrink_to_fit apparently calls shrink_to(0) internally. Then this code is used to keep some free capacity and avoid allocation when the map grows again. I dont think this is necessary, it smells like premature optimization because remove_older_than is only caused once an hour. You can change this to use shrink_to_fit.
dessalines
approved these changes
Jul 10, 2023
Nutomic
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Shrink capacity in `RateLimitStorage::remove_older_than` * Update rate_limiter.rs * rerun ci * rerun ci * rerun ci * Update rate_limiter.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents spikes in traffic from causing permanently increased memory usage.