Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Pagination doesn't work for GetComments if max_depth is set #3585

Closed
4 tasks done
leinardi opened this issue Jul 11, 2023 · 3 comments
Closed
4 tasks done

[Bug]: Pagination doesn't work for GetComments if max_depth is set #3585

leinardi opened this issue Jul 11, 2023 · 3 comments
Labels
area: api bug Something isn't working

Comments

@leinardi
Copy link

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

It seems not possible to fetch anything else than the first 300 comments if max_depth is set.

Steps to Reproduce

  1. Open a post with more than 300 comments, like this one: https://lemmy.ml/api/v3/comment/list?post_id=1846338&max_depth=8&page=1. The response will contain only the first 300.
  2. Try to fetch the next 300 increasing the page value: https://lemmy.ml/api/v3/comment/list?post_id=1846338&max_depth=8&page=2
  3. The same 300 from the 1st get will be retrieved.

Technical Details

This post contains 914 comments, what is the best way to fetch them with pagination and a max_depth value?
https://lemmy.ml/api/v3/post?id=1846338

Version

BE: 0.18.2

Lemmy Instance URL

lemmy.ml

@leinardi leinardi added the bug Something isn't working label Jul 11, 2023
@lionirdeadman
Copy link

This sounds related to #3306

@leinardi
Copy link
Author

@lionirdeadman oh yeah, that PR seems very related. I would still keep this issue open until a proper fix is available.

@Nutomic
Copy link
Member

Nutomic commented Mar 15, 2024

Duplicate of #3065

@Nutomic Nutomic marked this as a duplicate of #3065 Mar 15, 2024
@Nutomic Nutomic closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants