Change logic for determining comment default language (fixes #3451) #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
change-comment-default-lang-logic
branch
from
3e3473e
to
aaa447d
Compare
dessalines
approved these changes
Jul 21, 2023
Nutomic
added a commit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a comment without explicit language id, it would currently always use the post language. Users have reported many problems with this recently. One case is if the post language was previously allowed in the community, but later disallowed. Then all replies to that post without explicit language will throw an error.
The logic for default post language (based on overlap of user languages and community languages) seems to be working much more reliably, so we can use it for comments as well.
This change might allow us to get rid of the workaround in #2851 in the future.