[Bug]: Bad Prometheus metric performance due to endpoint
label explosion for images and feeds
#4431
Open
4 tasks done
Labels
bug
Something isn't working
Requirements
Summary
Prometheus metrics currently have performance issues due to label explosion of the
endpoint
label. This is handled for some endpoints (likeendpoint="/comment/{comment_id}
instead of using the actual ID) but not for others (likeendpoint="/feeds/u/user@instance.xml"
andendpoint="/pictrs/image/image_uuid.webp"
).Steps to Reproduce
lemmy_api_http_requests_duration_seconds_bucket
. For instancehistogram_quantile(0.99, sum by(le) (rate(lemmy_api_http_requests_duration_seconds_bucket[$__rate_interval])))
Technical Details
It's not a bug in the sense that logs will help. It's a performance bug, not a correctness issue. The system is working as designed, just with poor performance.
Suggested solutions
Do the same as the
endpoint="/comment/{comment_id}
strategy for image and feed endpoints as well.Version
BE 0.19.3
Lemmy Instance URL
Feddit.dk
The text was updated successfully, but these errors were encountered: