Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor CSS changes #704

Closed
evgip opened this issue May 9, 2020 · 5 comments
Closed

Minor CSS changes #704

evgip opened this issue May 9, 2020 · 5 comments

Comments

@evgip
Copy link
Contributor

evgip commented May 9, 2020

Firefox (76.0), Google Chrome (80.0.3987.100)...
lemmy Version v0.6.57

Vertical alignment:
lemmy

Indentation from the avatar:
lemmy2

<li className="nav-item">

+ mt-1

Which will add top indent

.mt-1, .my-1 {
    margin-top: 0.25rem !important;
}
@NicolasCARPi
Copy link

If you have to use !important in your css, you're doing something wrong ;)

@evgip
Copy link
Contributor Author

evgip commented May 15, 2020

@NicolasCARPi

!important is used in Bootstrap, this is the original code that I provided. If we add mt-1, we will enable the .mt-1, .m1 property from Bootstrap. We don’t use CSS here, we don’t add anything at all. Only mt-1 to indent. This is one of the solutions.

The meaning of the correction is to align the items in the header vertically. Other solutions may be used.

1

@NicolasCARPi
Copy link

Thanks @Toxu-ru for the precision.

@dessalines
Copy link
Member

Please do this as a PR, I'm not exactly sure what you're changing.

@evgip
Copy link
Contributor Author

evgip commented May 15, 2020

The question is closed. We will get a whole chain of changes. mt-1 was added to the top menu in one item.
1
Accordingly, we now get that the content in the header is not aligned. With the appearance of an Avatar there, the situation will only get worse. Because its size will expand the header.

All the solutions I've suggested here are patches, it's not exactly what's needed.

@evgip evgip closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants