Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there plans to support phpBB themes? #48

Open
mu-arch opened this issue Nov 2, 2022 · 4 comments
Open

Are there plans to support phpBB themes? #48

mu-arch opened this issue Nov 2, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mu-arch
Copy link

mu-arch commented Nov 2, 2022

Question in title, apologizes if this has been answered somewhere.

Edit: I see this has been mentioned here: #24

We should probably add some official mention around this though as it will be a highly requested feature.

@Tealk
Copy link
Collaborator

Tealk commented Nov 3, 2022

this is not so easy, because there is no standardized handling for the phpbb templates

also they all need to be customized to work with lemmy

@Nutomic Nutomic mentioned this issue Nov 3, 2022
@Nutomic
Copy link
Member

Nutomic commented Nov 3, 2022

The problem is that each phpBB theme includes its own HTML template files, which can be completely distinct.

If you want to make a theme work with lemmybb, you need to follow these steps:

  • Clone this repo
  • Place the theme's css files (and other assets) in assets/styles/
  • Rewrite everything in templates/ folder to make it work with theme's css and handlebars templating.

The last step is obviously the most complicated one. Filenames in templates folder are hardcoded in lemmybb, so you cant change them, and they dont relate to phpbb file structure because I took the HTML from a running phpbb site, not from the raw templates files.

Basically there will be some trial and error to get things working. If you want to give it a try, I suggest you make a pull request with your changes, so others can follow along and help out. Once its working and if the theme is open source, we can include it with lemmybb to give some different choices to users.

@Nutomic Nutomic added enhancement New feature or request help wanted Extra attention is needed labels Nov 3, 2022
@mu-arch mu-arch changed the title Are phpBB theme supported or planned to get support? Are phpBB themes supported or planned to get support? Nov 3, 2022
@mu-arch mu-arch changed the title Are phpBB themes supported or planned to get support? Are there plans to support phpBB themes? Nov 3, 2022
@mu-arch
Copy link
Author

mu-arch commented Nov 3, 2022

How stable do you feel the codebase is right now for things like element names? I am very excited about this project but I want to wait until things are fleshed out so I don't wind up doing a lot of work twice.

@Nutomic
Copy link
Member

Nutomic commented Nov 3, 2022

Most of what you see in the templates are lines like {{{markdown site_data.site.site_view.site.sidebar}}}. That looks complicated but its really just using Lemmy structs directly from the api/database. That is completely stable and will not change. There are some things which might be refactored sooner or later such as pagination, but nothing major. And for now I can easily prioritize other work, there is plenty to do.

Btw if we can merge your theme into this repo, it should be easy to add test cases which detect breakage. That would help to stabilize the template rendering and make it easier to develop more themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants