Skip to content

Commit

Permalink
Merge pull request #506 from Lemoncode/fixaccessibilitybug/expand-but…
Browse files Browse the repository at this point in the history
…ton-and-css-dev-canvas

Change the labels of the expand nested fields button and add styles f…
  • Loading branch information
brauliodiez committed Jun 20, 2024
2 parents b2889e2 + 8c51e6a commit 1bf5e60
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
/* only for see the content while developing */
/*
z-index: 1;
background-color: rgba(0, 0, 0, 0.908); */
background-color: rgba(0, 0, 0, 0.908);
text-align: left;
padding-left: 2rem; */
/* comment for show accessibility canvas*/
width: 1px;
height: 1px;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ export const CanvasAccessible: React.FC<CanvasAccessibleProps> = props => {
}, []);

return (
//Maybe it needs something for better accessibility.
//Before, the screen reader read all the content and displayed
// the levels of the titles and the list of items, now read all like plain text.
<section
className={classes.screenReaderOnly}
tabIndex={-1}
Expand Down
4 changes: 2 additions & 2 deletions src/pods/edit-table/components/field.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ export const Field: React.FC<Props> = props => {
onClick={() => toggleExpand(field.id)}
aria-label={
expandedFields.has(field.id)
? 'contract nested fields'
: 'expand nested fields'
? `collapse nested fields of "${field.name}"`
: `expand nested fields of "${field.name}"`
}
>
{expandedFields.has(field.id) ? (
Expand Down

0 comments on commit 1bf5e60

Please sign in to comment.