Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3. Add collection editor headings #481

Closed
brauliodiez opened this issue May 22, 2024 · 0 comments · Fixed by #492
Closed

3. Add collection editor headings #481

brauliodiez opened this issue May 22, 2024 · 0 comments · Fixed by #492
Assignees
@deletidev
Labels
accesibility

Comments

@brauliodiez
Copy link
Member

  1. When clicking on "add collection," the dialog opens as H2, but in a modal, the dialog is what matters, as it is considered the top of the hierarchy because it is the only thing visible. Therefore, it should be an H1.
@brauliodiez brauliodiez changed the title Add collection editor headings 3. Add collection editor headings May 22, 2024
@deletidev deletidev mentioned this issue May 22, 2024
Merged
@deletidev deletidev linked a pull request May 22, 2024 that will close this issue
Change h2 to h1 in modal #492
Merged
brauliodiez added a commit that referenced this issue May 22, 2024
@brauliodiez
Merge pull request #492 from Lemoncode/fixaccessibilitybug/#481-3-Add…
aa0ff3f 
…-collection-editor-headings

Change h2 to h1 in modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deletidev deletidev

Labels
accesibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change h2 to h1 in modal Lemoncode/mongo-modeler
2 participants
@brauliodiez @deletidev