Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(syntax): support the new oneliner version #95

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

Akuukis
Copy link
Contributor

@Akuukis Akuukis commented Jan 10, 2024

Please merge an update for the beancount plugin "oneliner". See the improved syntax highlights below (includes PRs #92 #93 #94)

Ayu Mirage (before & after)

image
image

Monokai Classic (before & after)

image
image

Night Owl Dark (before & after)

image
image

@Lencerf
Copy link
Owner

Lencerf commented Jan 11, 2024

Hi Akuukis, thanks for the PR, have you ever sent your plug-in to upstream beancount?
Personally I am not a fan of writing everything in a single line.

Since this change is probably just for your own use case, I'd prefer not changing beancount.tmLanguage.

Maybe the acceptable way is,

  • send your plugin to upstream, make your oneline syntax part of the official beancount syntax

Or,

  • add a new language called beancount-oneline, add a beancount-oneline.tmLanguage, and define your syntax there.

@Akuukis
Copy link
Contributor Author

Akuukis commented Jan 11, 2024

Ok, extracted to a separate syntax file!

As per upstream, from the design docs Blais has written I clearly see he wants the beancount core lean and small, and thus I don't believe that such shorthands like oneliner (or my other plugins) have a place in core. But maybe there's a difference between "official syntax" and "code lives in core" and it's worth asking for, who knows, maybe that opens up possibilities for even nicer syntax and therefore a way for proper auto-completes.

@Lencerf Lencerf merged commit 6525211 into Lencerf:master Jan 12, 2024
@Akuukis Akuukis deleted the oneliner branch January 12, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants