Fixed root component args not being iterated

Lenni0451 · Apr 5, 2024 · 7a41b95 · 7a41b95
1 parent 2616a41
commit 7a41b95
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/MCStructs-text/src/main/java/net/lenni0451/mcstructs/text/utils/TextUtils.java b/MCStructs-text/src/main/java/net/lenni0451/mcstructs/text/utils/TextUtils.java
@@ -45,19 +45,15 @@ public static ATextComponent replace(final ATextComponent component, final Funct
         ATextComponent out = component.copy();
         out.getSiblings().clear();
         out = replaceFunction.apply(out);
-        for (ATextComponent sibling : component.getSiblings()) {
-            ATextComponent replace = replace(sibling, replaceFunction);
-            if (replace instanceof TranslationComponent) {
-                TranslationComponent translationComponent = (TranslationComponent) replace;
-                Object[] args = translationComponent.getArgs();
-                for (int i = 0; i < args.length; i++) {
-                    if (args[i] instanceof ATextComponent) {
-                        args[i] = replace((ATextComponent) args[i], replaceFunction);
-                    }
+        if (out instanceof TranslationComponent) {
+            Object[] args = ((TranslationComponent) out).getArgs();
+            for (int i = 0; i < args.length; i++) {
+                if (args[i] instanceof ATextComponent) {
+                    args[i] = replace((ATextComponent) args[i], replaceFunction);
                 }
             }
-            out.append(replace);
         }
+        for (ATextComponent sibling : component.getSiblings()) out.append(replace(sibling, replaceFunction));
         return out;
     }