Skip to content

Commit

Permalink
Workaround for cert-manager update spec issue (knative-extensions#3390)
Browse files Browse the repository at this point in the history
I'm setting the fields to what cert-manager expects so that
we don't run into this issue cert-manager/cert-manager#6408

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
  • Loading branch information
pierDipi committed Oct 11, 2023
1 parent 310891f commit e7017ef
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ spec:
app.kubernetes.io/component: kafka-broker-receiver
app.kubernetes.io/name: knative-eventing

duration: 2160h # 90d
renewBefore: 360h # 15d
# Use 0m0s so that we don't run into https://github.com/cert-manager/cert-manager/issues/6408 on the operator
duration: 2160h0m0s # 90d
renewBefore: 360h0m0s # 15d
subject:
organizations:
- local
isCA: false
privateKey:
algorithm: RSA
encoding: PKCS1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ spec:
app.kubernetes.io/component: kafka-channel-receiver
app.kubernetes.io/name: knative-eventing

duration: 2160h # 90d
renewBefore: 360h # 15d
# Use 0m0s so that we don't run into https://github.com/cert-manager/cert-manager/issues/6408 on the operator
duration: 2160h0m0s # 90d
renewBefore: 360h0m0s # 15d
subject:
organizations:
- local
isCA: false
privateKey:
algorithm: RSA
encoding: PKCS1
Expand Down
6 changes: 3 additions & 3 deletions data-plane/config/sink-tls/sink-ingress-tls-certificate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ spec:
app.kubernetes.io/component: kafka-sink-receiver
app.kubernetes.io/name: knative-eventing

duration: 2160h # 90d
renewBefore: 360h # 15d
# Use 0m0s so that we don't run into https://github.com/cert-manager/cert-manager/issues/6408 on the operator
duration: 2160h0m0s # 90d
renewBefore: 360h0m0s # 15d
subject:
organizations:
- local
isCA: false
privateKey:
algorithm: RSA
encoding: PKCS1
Expand Down

0 comments on commit e7017ef

Please sign in to comment.