This repository has been archived by the owner on Nov 21, 2017. It is now read-only.
Fix orientation #11
Closed
Fix orientation #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The orientation of LNNotificationBannerWindow is base on statusBarOrientation
Remove _notificationWindow on dismiss. Otherwise, the orientation of LNNotificationBannerWindow can not be changed on other UIViewController.
IOS6 compatibility
|
I will take a look some time soon. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create a new branch to pull request.
Make the orientation of LNNotificationBannerWindow changed base on statusBarOrientation
Sometimes, I hope the UIViewController force landscape. When trigger the LNNotification, it maybe portrait or landscape base on device. The LNNotification's Orientation is different with the UIViewController. If the LNNotification's Orientation is the same with the statusbar, the problem can be solved.