This repository has been archived by the owner on Nov 21, 2017. It is now read-only.
Fix Xcode 7 warning #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current build generated the warning: “Method override for the designated initializer of the superclass ‘init’ not found”. According to Apple Docs: “If a class provides one or more designated initializers, it must implement all of the designated initializers of its superclass.” I have added an override for the superclass designated initializer (init) which calls your designated initializer with nil parameters. If you prefer to make init unavailable you could add to there header instead: - (instancetype)init NS_UNAVAILABLE; It’s a judgement call which way to go.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current build generated the warning: “Method override for the
designated initializer of the superclass ‘init’ not found”.
According to Apple Docs: “If a class provides one or more designated
initializers, it must implement all of the designated initializers of
its superclass.”
I have added an override for the superclass designated initializer
(init) which calls your designated initializer with nil parameters. If
you prefer to make init unavailable you could add to there header
instead:
It’s a judgement call which way to go.