Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using custom presentation controller for popup interaction and animation #225

Closed
LeoNatan opened this issue Feb 10, 2018 · 1 comment

Comments

@LeoNatan
Copy link
Owner

https://developer.apple.com/library/content/featuredarticles/ViewControllerPGforiPhoneOS/DefiningCustomPresentations.html

https://developer.apple.com/library/content/featuredarticles/ViewControllerPGforiPhoneOS/CustomizingtheTransitionAnimations.html#//apple_ref/doc/uid/TP40007457-CH16-SW2

Currently for #211, I have implemented the animation using UIViewPropertyAnimator. It's buggy and doesn't behave as expected under certain cases. Also, people have requested that view appearance be communicated to the popup hosting controller.

I think I could simplify some of the presentation and transition code inside the framework by switching to using a custom presentation controller and an interactive presentation animator.

@LeoNatan
Copy link
Owner Author

Closing in favor of #348.

@LeoNatan LeoNatan removed this from the 3.0 milestone Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant