Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNPopupController 3.0 tracking #348

Closed
4 of 7 tasks
LeoNatan opened this issue Aug 25, 2019 · 9 comments
Closed
4 of 7 tasks

LNPopupController 3.0 tracking #348

LeoNatan opened this issue Aug 25, 2019 · 9 comments
Milestone

Comments

@LeoNatan
Copy link
Owner

LeoNatan commented Aug 25, 2019

I've started work on 3.0.

It is intended as a general rewrite of the entire presentation model. The idea is to use UIPresentationController subclasses with custom animation and interaction controllers. (#225)
This will greatly simplify the presentation system and allow many more features, such as "free" card presentation on iOS 13.

Planned features that will also make the cut for 3.0:

The goal is to support as much of the current feature set, as possible. Some minor changes to look and feel might happen due to the transition to presentation controllers. There are still some unknowns.

The effort is being implemented in the v3_0 branch.
So far, I have removed all legacy code, removed all old presentation code and have a proof of concept using the iOS 13 card presentation controller as the basis for popup presentation.

Todo:

  • Add support for full screen popup presentation
  • Add support for interactive ("Drag") presentation
  • Add support for iOS 13 interactive card presentation
  • Explore card presentations for iOS 12 and below
  • Explore non-full width presentations
  • Explore embedding the popup bar inside bottom bars, such as tab bars
  • Explore the possibility of the bar's background view extending under the hosting view's safe areas
@iDevelopper
Copy link
Contributor

Hi @LeoNatan , what about the progress of this WIP? Interactive presentations?

Do you have a little bit of time for that?

@LeoNatan
Copy link
Owner Author

Hello

I have not worked on this in some time. I have ideas, but haven't had the time. I hope to sit again on this branch soon.

@heysaik
Copy link

heysaik commented Apr 1, 2020

Any updates on this?

@LeoNatan
Copy link
Owner Author

LeoNatan commented Apr 1, 2020

Sorry, unfortunately I have not worked on this branch (or the framework) in a long while.

@LeoNatan LeoNatan unpinned this issue Jul 31, 2020
@LeoNatan
Copy link
Owner Author

LeoNatan commented Jun 7, 2021

https://developer.apple.com/documentation/uikit/uisheetpresentationcontroller?language=objc

This API now being public, including all the detents stuff, 3.0 can be implemented much more easily.

@purepure
Copy link

Love this lib. For here to say thank and also interested in this feature. Any update for 2023 ?
Thank!

@LeoNatan
Copy link
Owner Author

Hello, unfortunately, I have not made progress on 3.0, and the branch I once worked on is hopelessly outdated now.

Which feature specifically are you interested in?

@purepure
Copy link

Hopefully you got sometime and continue improve this lib. It is so great!
I am looking for ability of controlling drag/scroll event for something like Apple Music where they tint the background color or scale the Album cover bigger/smaller when user drag down/up. It make the movement become more attractive.
Anw, I think I can try difference approaching.
Thank you for the lib!

@LeoNatan
Copy link
Owner Author

LeoNatan commented Oct 1, 2023

I’ll close this issue. I don’t think what I once worked on can be resurrected. I have ideas how to implement transitions and animations. The rest (switching to UIPresentationController presentations) is just a huge undertaking that I don’t really have the time or will for, while Apple itself has abandoned their designs where non-full screen presentation was a thing.

@LeoNatan LeoNatan closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants