-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line follower example #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…ers with command line arguments and python argparse Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…nd fixed path for file with labels Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…g files and directories Signed-off-by: Bitterisland6 <2010olo@wp.pl>
… the first message from cmd_vel topic, fixed saved img filename, closing label file on shutdown Signed-off-by: Bitterisland6 <2010olo@wp.pl>
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…label (0.0, 0.0) Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…mous following the line with rover
…or line_follower.py script
…, with two lines track Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…h ros node for chosing hsv bounds for color mask Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…files with example hsv_bounds and dynamic_reconfigure config file Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…ists.txt for use of dynamic_reconfigure Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…ode with black Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…launch file Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…r_mask_finder node Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…ers for hsv color bounds Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…ine follower node Signed-off-by: Bitterisland6 <2010olo@wp.pl>
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
… args Signed-off-by: Bitterisland6 <2010olo@wp.pl>
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…private namespace Signed-off-by: Bitterisland6 <2010olo@wp.pl>
… masks Signed-off-by: Bitterisland6 <2010olo@wp.pl>
bjsowa
requested changes
May 6, 2022
I think the color mask should support values where hue_min > hue_max. In that case it should join 2 masks together like here: https://stackoverflow.com/a/30333177 |
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…dlines (about python buildins and instance method) Signed-off-by: Bitterisland6 <2010olo@wp.pl>
bjsowa
requested changes
May 11, 2022
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
… code review Signed-off-by: Bitterisland6 <2010olo@wp.pl>
… data into ready dataset for keras model Signed-off-by: Bitterisland6 <2010olo@wp.pl>
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…irectory is given as relative path Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…unction instead of hardcoding home directory path Signed-off-by: Bitterisland6 <2010olo@wp.pl>
bjsowa
approved these changes
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e with rosrun Signed-off-by: Bitterisland6 <2010olo@wp.pl>
… rights with chmod + x Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…es when train and validation dirs are nested paths Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…ing files to just copying Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…e from processed data, and clearing the working directory from zipped files Signed-off-by: Bitterisland6 <2010olo@wp.pl>
… zipping files Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…ge syntax error Signed-off-by: Bitterisland6 <2010olo@wp.pl>
… one pattern Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…file name ends with '.zip' Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…lack Signed-off-by: Bitterisland6 <2010olo@wp.pl>
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…pt to catkin_install_python section Signed-off-by: Bitterisland6 <2010olo@wp.pl>
bjsowa
requested changes
May 20, 2022
bjsowa
requested changes
May 20, 2022
Signed-off-by: Bitterisland6 <2010olo@wp.pl>
…rosparam Signed-off-by: Bitterisland6 <2010olo@wp.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.