Mecanum Wheel Odometry in firmware_message_converter #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitterisland6
force-pushed
the
mecanum
branch
from
18501b7
to
174b6a2
Compare
…erter Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Bitterisland6
force-pushed
the
mecanum
branch
from
174b6a2
to
8cafdfa
Compare
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
bjsowa
requested changes
Sep 20, 2023
leo_bringup/config/firmware.yaml
Outdated
There was a problem hiding this comment.
This file does not belong to this PR, delete it
Comment on lines
360
to
361
| bool wheel_odom_advertised; | ||
| bool wheel_odom_mecanum_advertised; |
There was a problem hiding this comment.
Use _ prefix for private member variables
There was a problem hiding this comment.
Removed those flags as I switched to different solution
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
Signed-off-by: Aleksander Szymański <bitterisland6@gmail.com>
bjsowa
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling of "/firmware/wheel_odom_mecanum" topic in firmware message converter script