Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now generates search.json after middleman build #6

Merged
merged 15 commits into from
Apr 4, 2015
Merged

Now generates search.json after middleman build #6

merged 15 commits into from
Apr 4, 2015

Conversation

bsclifton
Copy link
Contributor

Yet another pull request for you 😄 The core logic from commands.rb was broken out to a helper file

  1. The middleman swiftype thor command continues to work, no change
  2. Doing a regular build via middleman build with this plug-in activated will now generate the search.json
  3. The previous implementation for generating the search.json continues to work, via middleman swiftype --only-generate

…elper class and implemented it in the Thor subcommand. Put placeholder for the after_build event.
…nly-generate doesn't do a build anymore, since it's not needed.
@bsclifton bsclifton changed the title Now generates search.json after build Now generates search.json after middleman build Mar 31, 2015
@bsclifton bsclifton changed the title Now generates search.json after middleman build Now generates search.json after middleman build Mar 31, 2015
@bsclifton
Copy link
Contributor Author

Now includes several RSpec tests for all important features! 😄 Run using bundle exec rspec. Big thanks to @michaelrkn

LeonB added a commit that referenced this pull request Apr 4, 2015
Now generates search.json after `middleman build`
@LeonB LeonB merged commit 98a7fdb into LeonB:master Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants