forked from Code-the-Dream-School/06-jobs-api
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week10 #2
Open
Leonardo-Reyes-Munoz
wants to merge
18
commits into
main
Choose a base branch
from
week10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Week10 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created a new createJWT method on UserSchema which generates jwt token. Calls createJWT method within the auth.js controller to generate a new user token
set-up environment variables to contain a 256 encryption key and JWT_LIFETIME variable to increase user privacy
Updates login controller to verify user email and password against DB. Generates jwt token if email and password are correct
Starts logic within auth middleware. Looks for auth header and uses verifies token using jwt package
This updates the logic withing the createJob controller. It appends the createdBy attribute to the request body and utilizes the Job model to create a new job entry
This destructures the userId and the jobId from the req object. Utilitizes the mongoose .findOne filter method to find the appropiate job. Sends response with job if successful
This adds updateJob logic. Destructures company, position, userId, and jobId from req object. Utilizes mongoose findneAndUpdate method to update job. Throws error if jobId is not found or provides res object with updated job.
This destructures the userId and jobId from req object. Utilizes the findOneAndRemove() mongoose method to delete job with associtedid and user. Throws error if job is not found. Provides res object with status code 200
…plicate err response
This imports and invokes the following security packaages: helmet, cors, xss-clean, and express-rate-limit.
…ilize node instead of nodemon.
alexgs
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
params: { id: jobId }, | ||
} = req; | ||
|
||
if (company === '' || position === '') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't catch undefined
or null
values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs API part 2. Finish setting up controllers and add security packages. API has successfully launched to Render.com and Swagger API documentation has been created.