Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile on linux with musl libc #11

Closed
doughdemon opened this issue Dec 3, 2015 · 6 comments
Closed

Does not compile on linux with musl libc #11

doughdemon opened this issue Dec 3, 2015 · 6 comments

Comments

@doughdemon
Copy link

Fails with "unkown type name '__uint32_t'". The problem is that musl libc's <sys/types.h> defines _SYS_TYPES_H but not __uint32_t (though it does uint32_t and u_int32_t). musl cannot reliably be detected using macros.

Why can't <stdint.h> types be used by default or just 'unsigned int' for UINT32 and 'unsigned char' for UINT8?

@doughdemon
Copy link
Author

@Leont
Copy link
Owner

Leont commented Dec 4, 2015

Fails with "unkown type name '__uint32_t'". The problem is that musl libc's defines _SYS_TYPES_H but not __uint32_t (though it does uint32_t and u_int32_t). musl cannot reliably be detected using macros.

Actually, perl already defines a U32 and U8, it's probably easiest to reuse those.

Why can't types be used by default or just 'unsigned int' for UINT32 and 'unsigned char' for UINT8?

That is suboptimally portable, specially 'unsigned int'.

@doughdemon
Copy link
Author

doughdemon commented Dec 4, 2015 via email

@Leont
Copy link
Owner

Leont commented Dec 4, 2015

Right, int is only at least 32 bits.

Actually, it's only at least 16 bytes, though I don't think perl runs on any such platform.

@doughdemon
Copy link
Author

Leon Timmermans wrote:

Right, int is only at least 32 bits.

Actually, it's only at least 16 bytes, though I don't think perl runs on any such platform.

I forgot to add "on posix systems".

mwiencek added a commit to mwiencek/crypt-rijndael that referenced this issue Sep 16, 2016
@kentfredric
Copy link

I suspect the fix won't be different for armv7a, however, just got a second report here with $VERSION=1.13 ( also on gentoo as the original report was )

https://bugs.gentoo.org/612096

@Leont Leont closed this as completed in #12 Dec 23, 2018
Leont pushed a commit that referenced this issue Dec 23, 2018
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Jul 10, 2019
- Convert to EAPI6

Upstream:
- Fix UINT32 and UINT8 for musl libc

Bug: https://bugs.gentoo.org/612096
Bug: Leont/crypt-rijndael#11
Package-Manager: Portage-2.3.66, Repoman-2.3.16
Signed-off-by: Kent Fredric <kentnl@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants