Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple parser fuzzer #40

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Conversation

killercup
Copy link
Contributor

No description provided.

@killercup
Copy link
Contributor Author

killercup commented Nov 27, 2017

Protip: If you don't have much time to contribute to a project, have a computer fuzzer do it for you 😉

Edit: Had some time, fixed fuzzer panics

Edit 2: Couldn't find any new stuff after 10M runs with a coverage of 2512 code paths.

@LeopoldArkham
Copy link
Owner

Thanks Pascal, good to see you here!

Since I have you, any outstanding API requirements you can think of? If so, feel free to mention them in #8

@LeopoldArkham LeopoldArkham merged commit 015fc08 into LeopoldArkham:master Nov 27, 2017
@markcol
Copy link
Contributor

markcol commented Dec 4, 2017

@killercup could you add documentation about how to run the fuzzing tests, or include it as part of the tests, probably ignored by default but included with a filter.

@killercup
Copy link
Contributor Author

killercup commented Dec 4, 2017

@markcol this uses cargo-fuzz (cargo install cargo-fuzz) and its typical usage (cargo fuzz run parse --release). I can add a short note to the Readme.

Running the fuzzer on CI might be a nice idea, as it's a very fast fuzzer (32k iterations/s), e.g. with a timeout (cargo fuzz run parse --release -- -max_len=4100 -max_total_time=10). @LeopoldArkham, is that something you want? Maybe as another job on Travis?

@LeopoldArkham
Copy link
Owner

Yes, via Travis seems like the way to do it; Although I'm not certain it should fail the build... Fuzzer errors are kind of esoteric.
I could be swayed either way.

@killercup killercup mentioned this pull request Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants