Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n #160

Merged
merged 27 commits into from
Oct 27, 2019
Merged

i18n #160

merged 27 commits into from
Oct 27, 2019

Conversation

jarjan
Copy link
Member

@jarjan jarjan commented Oct 3, 2019 •
edited
Loading

I added basic functionality for internationalization or shortly i18n. Translation string are located under src/locales folder. For now I only i18n-ed footer and header. And snapshot testing is broken, need to fix :(

  • Fix snapshot testing
  • Error page
  • Blog page
  • Contact page
  • Friends page
  • Team page
  • Gallery page
  • Home page
  • Partners page
  • Projects page
  • Subscribe page
  • Support page
  • Values page

danielstreif
danielstreif reviewed Oct 4, 2019
View reviewed changes
src/locales/de.json Outdated Show resolved Hide resolved
@pheeria
Copy link
Member

pheeria commented Oct 4, 2019

This is really cool! 🥇
Do you have an idea how we can avoid usage of tons of lines of translations in the single json and have them nicely split across multiple files?

pheeria
pheeria reviewed Oct 4, 2019
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
@jarjan
Copy link
Member Author

jarjan commented Oct 5, 2019

i18n – internationalization

@jarjan
Copy link
Member Author

jarjan commented Oct 5, 2019

This is really cool! 🥇
Do you have an idea how we can avoid usage of tons of lines of translations in the single json and have them nicely split across multiple files?

Nope, usually all translations are done in one file per locale.

@pheeria
Copy link
Member

pheeria commented Oct 5, 2019

Is this pr wip or do you want to merge and split it into separate tasks?

@jarjan jarjan added the wip Work In Progress label Oct 6, 2019
@pheeria pheeria added this to In progress in Roadmap to v1.1 Oct 8, 2019
@jarjan jarjan removed the wip Work In Progress label Oct 25, 2019
@danielstreif danielstreif moved this from In progress to Review in Roadmap to v1.1 Oct 25, 2019
danielstreif
danielstreif approved these changes Oct 25, 2019
View reviewed changes
Copy link
Collaborator

@danielstreif danielstreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pheeria
pheeria reviewed Oct 26, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@pheeria pheeria merged commit 40ce677 into master Oct 27, 2019
Roadmap to v1.1 automation moved this from Review to Done Oct 27, 2019
@pheeria pheeria deleted the feature/i18n branch October 27, 2019 12:17
@pheeria pheeria mentioned this pull request Oct 27, 2019
Closed
@pheeria pheeria removed this from Done in Roadmap to v1.1 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheeria pheeria pheeria left review comments

@starmaerker starmaerker starmaerker approved these changes

@danielstreif danielstreif danielstreif approved these changes

@cappyccino cappyccino Awaiting requested review from cappyccino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jarjan @pheeria @starmaerker @danielstreif