Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noopener to calendar links #177

Merged
merged 2 commits into from
Oct 13, 2019
Merged

Add noopener to calendar links #177

merged 2 commits into from
Oct 13, 2019

Conversation

danielstreif
Copy link
Collaborator

Added noopener to calendar links as suggested by Chrome Audit.

pheeria
pheeria approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@pheeria pheeria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅 👍

Did you try running Audit again? Were there any other rel="noopener" issues?

@pheeria pheeria mentioned this pull request Oct 12, 2019
Closed
@pheeria pheeria added this to Review in Roadmap to v1.1 Oct 12, 2019
@danielstreif
Copy link
Collaborator Author

Did you try running Audit again? Were there any other rel="noopener" issues?

Good call, forgot the images had links as well.

@danielstreif danielstreif merged commit a9375e8 into master Oct 13, 2019
Roadmap to v1.1 automation moved this from Review to Done Oct 13, 2019
@danielstreif danielstreif deleted the features/noopener branch October 13, 2019 14:52
@pheeria
Copy link
Member

pheeria commented Oct 27, 2019

Fixed #170

@pheeria pheeria removed this from Done in Roadmap to v1.1 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarjan jarjan jarjan approved these changes

@pheeria pheeria pheeria approved these changes

@cappyccino cappyccino Awaiting requested review from cappyccino

@starmaerker starmaerker Awaiting requested review from starmaerker starmaerker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielstreif @pheeria @jarjan