Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forceDisabled and classnames dependency #79

Closed
wants to merge 2 commits into from

Conversation

calderhayes
Copy link

Hello,

Thanks for this library, it looks so simple yet feature complete.

I have one minor adjustment, I noticed that it was included in a pull request before disappearing after a refactor (I think).

It has popped up before in the issues.

Basically I require an override on the disabled property when processing the form data asynchronously. I don't want the user to click the submit button while this is going on.

I also ran into an issue where classnames was required, but not in the npm list of dependencies causing the unit tests to break.

Thanks,

Calder

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4d1e92a on calderhayes:master into aa2b38c on Lesha-spr:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants