-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable Erlang benchmark #147
Comments
Perhaps @fenollp , the local Erlang champion, you could take a look in spare time? :) |
Ah indeed there is an issue with unary calls made from a Go client. I am tracking this here and will dig further once I find some time. |
@fenollp thanks! |
Yo, I'm the author of grpcbox and hope to help. I've not been doing much of anything recently though because I've been on paternity leave :), but want to get this figured out. I see I've already been ignoring an issue on the repo itself :( |
Hi Tristan! Congrats :) and thanks for responding. As you note there's this issue of the gPRC stream being unexpectedly reset during unary calls from a gRPC-go client. If you can find some time to look into this that'd be very helpful :) |
Closing this since the erlang benchmark works now. |
I should have linked the PR to this issue. |
Weird, I see I commented back when I was on my first paternity leave and now I've run into this again via a tweet during my second leave :). Anyway, I saw our numbers are the worst, hehe. Recently had some major changes to the HTTP/2 client and server merged so hopefully that is going to change. I haven't published the new versions to hex yet but opened up a PR to bump the benchmark #363 |
Erlang benchmark stopped working (on my local machine all requests failed according to ghz report). Would be nice to identify the issue and resolve it. I temporarily disabled it to unblock CI.
The text was updated successfully, but these errors were encountered: