Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Erlang benchmark #147

Closed
LesnyRumcajs opened this issue May 19, 2021 · 8 comments
Closed

Re-enable Erlang benchmark #147

LesnyRumcajs opened this issue May 19, 2021 · 8 comments

Comments

@LesnyRumcajs
Copy link
Owner

LesnyRumcajs commented May 19, 2021

Erlang benchmark stopped working (on my local machine all requests failed according to ghz report). Would be nice to identify the issue and resolve it. I temporarily disabled it to unblock CI.

@LesnyRumcajs
Copy link
Owner Author

Perhaps @fenollp , the local Erlang champion, you could take a look in spare time? :)

@fenollp
Copy link
Collaborator

fenollp commented May 20, 2021

Ah indeed there is an issue with unary calls made from a Go client. I am tracking this here and will dig further once I find some time.

@LesnyRumcajs
Copy link
Owner Author

@fenollp thanks!

@tsloughter
Copy link
Contributor

Yo, I'm the author of grpcbox and hope to help. I've not been doing much of anything recently though because I've been on paternity leave :), but want to get this figured out. I see I've already been ignoring an issue on the repo itself :(

@fenollp
Copy link
Collaborator

fenollp commented May 24, 2021

Hi Tristan! Congrats :) and thanks for responding.

As you note there's this issue of the gPRC stream being unexpectedly reset during unary calls from a gRPC-go client.

If you can find some time to look into this that'd be very helpful :)

@Trisfald
Copy link
Collaborator

Closing this since the erlang benchmark works now.

@fenollp
Copy link
Collaborator

fenollp commented Jan 10, 2022

I should have linked the PR to this issue.
FYI grpcbox (actually, chatterbox) still requires some patching. See the PR's dependency override.

@tsloughter
Copy link
Contributor

Weird, I see I commented back when I was on my first paternity leave and now I've run into this again via a tweet during my second leave :).

Anyway, I saw our numbers are the worst, hehe. Recently had some major changes to the HTTP/2 client and server merged so hopefully that is going to change.

I haven't published the new versions to hex yet but opened up a PR to bump the benchmark #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants