Update LanguageRedirectMiddleware.php #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading typoscript settings like this
[traverse(page, "uid") in [968,967,202,965,969]]
config.tx_locate = 0
[ELSE]
config.tx_locate = 1
[GLOBAL]
does not work reliable with BackendConfigurationManager. If we use the ConfigurationManager to read frontend typoscript config, it works as expected.
As far as I see, the BackendConfigurationManager is not really supposed to read frontend typoscript code anyway. See comment at the start of the class:
/*
* Load TypoScript of a page in backend mode.
*
* Extbase Backend modules can be configured with Frontend TypoScript. This is of course a very
* bad thing, but it is how it is ^^ (we'll get rid of this at some point, promised!)
*/
|
I'm sorry, I committed the wrong code :( Will open another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace reading frontend typoscript settings with BackendConfigurationManager in LanguageRedirectMiddleware. This PR replaces reading frontend typoscript with ConfigurationManager instad of BackendConfigurationManager
Regards
Mike