Improve performance of backend module with many log entries #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balasch
reviewed
Mar 20, 2024
Classes/Controller/LogController.php
Outdated
Comment on lines
89
to
90
| 'previousPage' => ($currentPage - 1) > 0 ? $currentPage - 1 : null, | ||
| 'nextPage' => $totalPages > $currentPage ? $currentPage + 1 : null, |
There was a problem hiding this comment.
null is fine for me, as it is not page 0 but null as in »not defined«.
Comment on lines
36
to
54
| public function __construct(Filter $filter, LogRepository $logRepository) | ||
| { | ||
| $this->from = new \DateTime(); | ||
| $this->till = new \DateTime(); | ||
| $count = $logEntries->count(); | ||
|
|
||
| if ($count > 0) { | ||
| $this->till->setTimestamp($logEntries->getFirst()->getTstamp()); | ||
| $i = 1; | ||
| if ($filter->getFrom() !== null) { | ||
| $this->from->setTimestamp($filter->getFrom()); | ||
| } else { | ||
| $this->from->setTimestamp($logRepository->getFirstTimestampByFilter($filter)); | ||
| } | ||
|
|
||
| /** @var Log $logEntry */ | ||
| foreach ($logEntries as $logEntry) { | ||
| $this->traffic += $logEntry->getFileSize(); | ||
| if ($i === $count) { | ||
| $this->from->setTimestamp($logEntry->getTstamp()); | ||
| } | ||
| $i++; | ||
| $this->till = new \DateTime(); | ||
| if ($filter->getTill() !== null) { | ||
| $this->till->setTimestamp($filter->getTill()); | ||
| } else { | ||
| if ($logRepository->getFirstTimestampByFilter($filter, true) > 0) { | ||
| $this->till->setTimestamp($logRepository->getFirstTimestampByFilter($filter, true)); | ||
| } | ||
| } | ||
|
|
||
| $this->traffic = $logRepository->getTrafficSumByFilter($filter); |
There was a problem hiding this comment.
Does it really make sense to start the entire query in the constructor? What if this information is not needed?
There was a problem hiding this comment.
I think this is okay, as long as this class doesn't change it's purpose. Everything other method is a pure getter based on the class initialization.
bmheins
reviewed
Mar 21, 2024
| ->count('uid') | ||
| ->executeQuery() | ||
| ->fetchOne() ?? 0; | ||
| } |
There was a problem hiding this comment.
I would put $queryBuilder->...->fetchOne() ?? 0 into parentheses, so that the cast goes against the whole construct (not really necessary here, but looks better to me).
bmheins
reviewed
Mar 21, 2024
| ->orderBy('tstamp', $reverse ? 'DESC' : 'ASC') | ||
| ->executeQuery() | ||
| ->fetchOne() ?? 0; | ||
| } |
bmheins
reviewed
Mar 21, 2024
| ->selectLiteral('SUM(file_size) AS sum') | ||
| ->executeQuery() | ||
| ->fetchOne() ?? 0.0; | ||
| } |
bmheins
reviewed
Mar 21, 2024
| @@ -34,25 +33,25 @@ class Statistic | |||
| */ | |||
| protected $till; | |||
There was a problem hiding this comment.
protected \DateTime $till; (and the same for the lines above).
bmheins
reviewed
Mar 21, 2024
| if ($filter->getTill() !== null) { | ||
| $this->till->setTimestamp($filter->getTill()); | ||
| } else { | ||
| if ($logRepository->getFirstTimestampByFilter($filter, true) > 0) { |
There was a problem hiding this comment.
Change
} else {
if ...to
} elseif ...
balasch
approved these changes
Mar 22, 2024
bmheins
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.