Allow to pass NULL for a parameter with type hinting and default value NULL #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a function parameter with a type hint has a default value of
NULL
, passingNULL
instead of a valid class instance is allowed (according the the PHP documentation at http://php.net/manual/en/language.oop5.typehinting.php). On the other hand, theinstanceof
operator does of course not recognizeNULL
as an instance of a given class.This pull request would allow to pass NULL via the
contructParams
whenever the default value is set toNULL
; I'm not sure how to properly solve this also for the substitutions. It should be easy to forward-port this tomaster
; unfortunately, I don't have a PHP 5.6 setup readily available at the moment.