Update abstract-leveldown to the latest version 🚀 #32

greenkeeper · 2018-01-20T15:39:02Z

Closes #33

Version 4.0.0 of abstract-leveldown was just published.

Dependency	abstract-leveldown
Current Version	3.0.0
Type	dependency

The version 4.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of abstract-leveldown.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.

Commits

The new version differs by 50 commits.

0d942fd 4.0.0
18319ac add node 9 to travis
cdc560c prepare changelog for new release
1656bcd add UPGRADING.md (#188)
767fbdb remove .jshintrc
0bd84a8 add @vweevers to contributors
71bd174 Update changelog (#181)
bcdc953 Merge pull request #180 from ralphtheninja/master
6f5a3d9 normalize readme
48707e1 Merge pull request #178 from Level/remove-is-leveldown
97938f1 :fire: remove is-leveldown
54db15f Setup iterator options (#176)
72fcae9 Merge pull request #175 from Level/test-common-defaults
2ed07e5 :fire: remove testBuffer
3f24eba make testCommon.js the default value for testCommon parameter

There are 50 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper bot 🌴

ralphtheninja · 2018-01-22T22:46:58Z

Added tweak should make #33 work

@vweevers I tried testing this locally on levelup but if I do npm link deferred-leveldown I get some error (it works if I point out this branch directly). Iirc you had a similar issue (I forget where it was) where you had problems with npm link. Does it ring a bell?

ralphtheninja · 2018-01-22T22:49:06Z

deferred-leveldown.js


 function DeferredLevelDOWN (db) {
  AbstractLevelDOWN.call(this, '')
  this._db = db
  this._operations = []
  this._iterators = []
+  closed(this)


Note that I moved this from the prototype to this since we need to know the properties of db to determine if approximateSize is present or not.

ralphtheninja · 2018-01-22T22:50:12Z

deferred-leveldown.js

      return this._db[m].apply(this._db, arguments)
    }
  })
+  if (self._db.approximateSize) {


This point of the code could be a seam for applying a manifest when opening

ralphtheninja · 2018-01-22T22:50:27Z

deferred-leveldown.js

      this._operations.push({ method: m, args: arguments })
    }
  })
-  obj._iterator = function (options) {
+  if (typeof self._db.approximateSize === 'function') {


This point of the code could be a seam for applying a manifest when closing

ralphtheninja · 2018-01-22T22:50:50Z

If anyone feels like adding more tests to this branch. Please go ahead.

vweevers · 2018-01-23T09:15:44Z

I tried testing this locally on levelup but if I do npm link deferred-leveldown I get some error (it works if I point out this branch directly). Iirc you had a similar issue (I forget where it was) where you had problems with npm link. Does it ring a bell?

@ralphtheninja I had two issues with npm link: typescript (fails to compile, Level/memdown#101) and browserify (throws error about Buffer, Level/abstract-leveldown#172).

it works if I point out this branch directly

Same for me.

vweevers · 2018-01-23T09:23:40Z

deferred-leveldown.js

@@ -41,29 +42,40 @@ DeferredLevelDOWN.prototype._close = function (callback) {
  })
 }

-function open (obj) {
+function open (self) {


+1 on renaming obj

vweevers · 2018-01-23T09:26:23Z

deferred-leveldown.js

 }

-function closed (obj) {
+function closed (self, db) {


The db argument is unused?

Good catch. I originally added it but later changed to self._db inside the function.

vweevers · 2018-01-23T09:29:24Z

If anyone feels like adding more tests to this branch. Please go ahead.

Let's add tests for stores with and without approximateSize.

ralphtheninja · 2018-01-25T10:16:09Z

Let's add tests for stores with and without approximateSize.

Updated.

ralphtheninja · 2018-01-28T18:05:24Z

major or minor?

ralphtheninja · 2018-01-30T09:08:11Z

@vweevers I'm thinking we should release new majors for everything that's inheriting from abstract-leveldown@4, i.e. deferred-leveldown, leveldown and encoding-down. Even though deferred-leveldown and encoding-down are special "stores".

vweevers · 2018-01-30T10:20:22Z

@ralphtheninja that would be the safer route, yes. Otherwise we have to carefully look at each one to see if the changes in abstract-leveldown affect it in a breaking way.

ralphtheninja · 2018-02-02T23:21:46Z

I think we'll be fine to release deferred-leveldown without bumping major since it's the actual store passed to it in the constructor that really matters. So I'm thinking a patch will be fine.

That said, thinking is not good enough, so it would be nice to get some more information on how this works. I'll start with some npm link galore locally. Would it be enough if levelup-tests worked fine with a linked deferred-leveldown?

ralphtheninja · 2018-02-05T13:49:15Z

Ok, I've tested level and levelup by using npm link and things work fine. I'd like to start releasing deferred-leveldown since levelup depends on it (and then level-packager and later level).

I think I want to release new major versions of deferred-leveldown and encoding-down after all, since they technically are implementations that inherits breaking changes from abstract-leveldown, even though they aren't stores themselves.

@vweevers @juliangruber WDYT?

vweevers · 2018-02-08T09:41:33Z

since they technically are implementations that inherits breaking changes

Agree. Standing on principle removes the need to debate cases like these.

fix(package): update abstract-leveldown to version 4.0.0

1e9314a

greenkeeper bot added the dependencies Pull requests that update a dependency file label Jan 20, 2018

ralphtheninja mentioned this pull request Jan 20, 2018

abstract-leveldown@4.0.0 Level/community#15

Closed

7 tasks

defer approximateSize separately

5b53018

ralphtheninja reviewed Jan 22, 2018

View reviewed changes

vweevers reviewed Jan 23, 2018

View reviewed changes

ralphtheninja added 2 commits January 23, 2018 10:54

remove unused db parameter

40d18de

add test for stores not supporting approximateSize

3d00bf4

ralphtheninja added this to In progress in Level (old board) Jan 25, 2018

ralphtheninja moved this from In progress to Review in Level (old board) Jan 27, 2018

vweevers approved these changes Jan 28, 2018

View reviewed changes

ralphtheninja merged commit 346cf39 into master Jan 28, 2018

Level (old board) automation moved this from Review to Done Jan 28, 2018

greenkeeper bot deleted the greenkeeper/abstract-leveldown-4.0.0 branch January 28, 2018 18:08

ralphtheninja mentioned this pull request Jan 28, 2018

Remove approximateSize test #33

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update abstract-leveldown to the latest version 🚀 #32

Update abstract-leveldown to the latest version 🚀 #32

greenkeeper bot commented Jan 20, 2018 •

edited by ralphtheninja

Loading

ralphtheninja commented Jan 22, 2018 •

edited

Loading

ralphtheninja Jan 22, 2018

ralphtheninja Jan 22, 2018

ralphtheninja Jan 22, 2018

ralphtheninja commented Jan 22, 2018

vweevers commented Jan 23, 2018 •

edited

Loading

vweevers Jan 23, 2018

vweevers Jan 23, 2018

ralphtheninja Jan 23, 2018

vweevers commented Jan 23, 2018

ralphtheninja commented Jan 25, 2018

ralphtheninja commented Jan 28, 2018

ralphtheninja commented Jan 30, 2018

vweevers commented Jan 30, 2018

ralphtheninja commented Feb 2, 2018 •

edited

Loading

ralphtheninja commented Feb 5, 2018

vweevers commented Feb 8, 2018

Update abstract-leveldown to the latest version 🚀 #32

Update abstract-leveldown to the latest version 🚀 #32

Conversation

greenkeeper bot commented Jan 20, 2018 • edited by ralphtheninja Loading

Version 4.0.0 of abstract-leveldown was just published.

ralphtheninja commented Jan 22, 2018 • edited Loading

ralphtheninja Jan 22, 2018

Choose a reason for hiding this comment

ralphtheninja Jan 22, 2018

Choose a reason for hiding this comment

ralphtheninja Jan 22, 2018

Choose a reason for hiding this comment

ralphtheninja commented Jan 22, 2018

vweevers commented Jan 23, 2018 • edited Loading

vweevers Jan 23, 2018

Choose a reason for hiding this comment

vweevers Jan 23, 2018

Choose a reason for hiding this comment

ralphtheninja Jan 23, 2018

Choose a reason for hiding this comment

vweevers commented Jan 23, 2018

ralphtheninja commented Jan 25, 2018

ralphtheninja commented Jan 28, 2018

ralphtheninja commented Jan 30, 2018

vweevers commented Jan 30, 2018

ralphtheninja commented Feb 2, 2018 • edited Loading

ralphtheninja commented Feb 5, 2018

vweevers commented Feb 8, 2018

greenkeeper bot commented Jan 20, 2018 •

edited by ralphtheninja

Loading

ralphtheninja commented Jan 22, 2018 •

edited

Loading

vweevers commented Jan 23, 2018 •

edited

Loading

ralphtheninja commented Feb 2, 2018 •

edited

Loading