Standard #71
Merged
Standard #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a lot to do with these tests. They might fail due to race conditions. I have tested locally and sometimes they pass. |
|
Note that this will fail completely on node 10, since we're trying to compile an older version of |
vweevers
approved these changes
Jul 2, 2018
vweevers
reviewed
Jul 2, 2018
level-ttl.js
Outdated
| return db._ttl._stopAfterCheck = callback | ||
| if (db._ttl._checkInProgress) { | ||
| db._ttl._stopAfterCheck = callback | ||
| return db._ttl._stopAfterCheck |
There was a problem hiding this comment.
Can you add a TODO comment here, to check whether we need the return value? I'm guessing we don't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69