Merge pull request #61 from Level/iterator-memleak-1

Iterator memleak 1 from Level/leveldown#264
Level · Jun 19, 2018 · 06e39e9 · 06e39e9
2 parents d067069 + 5d3553c
commit 06e39e9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/src/common.h b/src/common.h
@@ -13,6 +13,7 @@ namespace leveldown {
 NAN_INLINE bool BooleanOptionValue(v8::Local<v8::Object> options,
                                    const char* _key,
                                    bool def = false) {
+  Nan::HandleScope scope;
   v8::Local<v8::String> key = Nan::New(_key).ToLocalChecked();
   return !options.IsEmpty()
     && options->Has(key)
@@ -23,6 +24,7 @@ NAN_INLINE bool BooleanOptionValue(v8::Local<v8::Object> options,
 NAN_INLINE uint32_t UInt32OptionValue(v8::Local<v8::Object> options,
                                       const char* _key,
                                       uint32_t def) {
+  Nan::HandleScope scope;
   v8::Local<v8::String> key = Nan::New(_key).ToLocalChecked();
   return !options.IsEmpty()
     && options->Has(key)

diff --git a/src/iterator.cc b/src/iterator.cc
@@ -76,6 +76,14 @@ Iterator::~Iterator () {
     delete start;
   if (end != NULL)
     delete end;
+  if (lt != NULL)
+    delete lt;
+  if (gt != NULL)
+    delete gt;
+  if (lte != NULL)
+    delete lte;
+  if (gte != NULL)
+    delete gte;
 };
 
 bool Iterator::GetIterator () {

diff --git a/src/iterator_async.cc b/src/iterator_async.cc
@@ -33,6 +33,7 @@ void NextWorker::Execute () {
 }
 
 void NextWorker::HandleOKCallback () {
+  Nan::HandleScope scope;
   size_t idx = 0;
 
   size_t arraySize = result.size() * 2;