Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor worker cleanup into BaseWorker::DoFinally() #617

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Refactor worker cleanup into BaseWorker::DoFinally() #617

merged 1 commit into from
Apr 26, 2019

Conversation

vweevers
Copy link
Member

Cherry picked from #601.

@vweevers vweevers added semver-patch Bug fixes that are backward compatible refactor Requires or pertains to refactoring labels Apr 26, 2019
@vweevers vweevers requested a review from peakji April 26, 2019 08:11
@vweevers vweevers added this to In progress in Level (old board) via automation Apr 26, 2019
@vweevers vweevers moved this from In progress to Review in Level (old board) Apr 26, 2019
@vweevers vweevers merged commit efcf3d3 into master Apr 26, 2019
Level (old board) automation moved this from Review to Done Apr 26, 2019
@vweevers vweevers deleted the refactor-worker-cleanup branch April 26, 2019 15:43
@braydonf braydonf mentioned this pull request Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peakji peakji peakji approved these changes

Assignees
No one assigned
Labels
refactor Requires or pertains to refactoring semver-patch Bug fixes that are backward compatible
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vweevers @peakji