Fix android arm64 prebuild by disabling exceptions #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran |
ralphtheninja
approved these changes
Feb 22, 2020
|
5.5.1 (published shortly after 5.5.0, for which I had already pushed git tags but I couldn't publish yet). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: loading the android-arm64 prebuild failed with "cannot locate symbol _Unwind_Resume". Likely because that symbol does not exist (or is hidden) on some android devices. I could not positively confirm that because I could not get
gdborlldbto work in termux. Luckily we don't have to, because_Unwind_Resumeis a function used for exceptions, which we don't need AFAICT.Solution: disable exceptions, on both our code and leveldb code.
Closes #705.
@christianbundy, /cc @staltz as the author of #411 which enabled exceptions.