Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use napi_create_int64 for approximate size #777

Merged
merged 1 commit into from
Aug 1, 2021
Merged

use napi_create_int64 for approximate size #777

merged 1 commit into from
Aug 1, 2021

Conversation

larskuhtz
Copy link
Contributor

@larskuhtz larskuhtz commented Jul 27, 2021 •
edited by vweevers

Closes #776.

@larskuhtz larskuhtz mentioned this pull request Jul 27, 2021
Closed
@larskuhtz larskuhtz force-pushed the fix/approximate-size-overflow branch from 61c0e39 to 6483ccb Compare July 27, 2021 22:15
vweevers
vweevers approved these changes Jul 31, 2021
View reviewed changes
Copy link
Member

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will land after #764 (without it, we don't have a complete test matrix).

@vweevers vweevers added this to Review in Level (old board) Jul 31, 2021
@vweevers vweevers merged commit 8740057 into Level:master Aug 1, 2021
Level (old board) automation moved this from Review to Done Aug 1, 2021
@vweevers
Copy link
Member

vweevers commented Aug 1, 2021

6.0.1

@larskuhtz larskuhtz mentioned this pull request Aug 1, 2021
Merged
vweevers pushed a commit to Level/rocksdb that referenced this pull request Aug 1, 2021
@larskuhtz
Support approximateSize() on db bigger than 4 GB (#175)
891bb7a 
By using napi_create_int64 instead of napi_create_int32.

Ported from Level/leveldown#777.
@nodech nodech mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support more than 32bit ApproximateSize bindings
2 participants
@larskuhtz @vweevers