Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Ubuntu 16.04 with CentOS 7 for prebuilds #674

Merged
merged 1 commit into from Oct 4, 2019
Merged

Replace Ubuntu 16.04 with CentOS 7 for prebuilds #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion .travis.yml
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@ jobs:
env: [TEST=1]
- os: linux
node_js: node
env: [TEST=1, TEST_ELECTRON=1, BUILD_CMD=prebuild, BUILD_GROUP=linux-x64]
env: [TEST=1, TEST_ELECTRON=1]
addons:
apt:
packages:
Expand All @@ -27,6 +27,11 @@ jobs:
- os: osx
node_js: node
env: [TEST=1, TEST_ELECTRON=1, BUILD_CMD=prebuild, BUILD_GROUP=darwin-x64]
Comment on lines 27 to 29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vweevers Side note. Why isn't osx using if: tag is present?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because that job runs tests too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding of this is that if: tag is present says "only invoke this if the current commit is tagged, so is probably a release that needs a prebuild". Otherwise it's just a normal test run. So osx gets test runs and prebuilds, but the prebuild-only jobs (arm and alpine) only get invoked when you need a prebuild and they don't get tests.

Maybe it's a good idea to also invoke alpine and centos7 builds on normal commits, not just tagged ones, and run the tests as well inside those containers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running tests in docker containers would make build times too long IMO.

- name: centos7
os: linux
node_js: node
env: [BUILD_CMD=prebuild-centos7, BUILD_GROUP=linux-x64, NPM_CONFIG_IGNORE_SCRIPTS=1]
if: tag is present
- name: arm
os: linux
node_js: node
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -22,7 +22,8 @@
"prebuild-linux-arm64": "IMAGE=linux-arm64 ./scripts/cross-compile --tag-armv",
"prebuild-android-armv7": "IMAGE=android-armv7 ./scripts/cross-compile --tag-armv",
"prebuild-android-arm64": "IMAGE=android-arm64 ./scripts/cross-compile --tag-armv",
"prebuild-alpine": "IMAGE=alpine ./scripts/cross-compile --tag-libc"
"prebuild-alpine": "IMAGE=alpine ./scripts/cross-compile --tag-libc",
"prebuild-centos7": "IMAGE=centos7-devtoolset7 ./scripts/cross-compile"
},
"dependencies": {
"abstract-leveldown": "~6.1.1",
Expand Down