Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .json file ending to leveldown package #420

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

PascalTemel
Copy link
Contributor

The missing file ending resulted in build issues in our project.

@ralphtheninja ralphtheninja merged commit 3abe2fa into Level:master Mar 2, 2017
@ralphtheninja
Copy link
Member

Thanks!

1.3.5 (yeah managed to release 1.3.4 before merging, doh)

@juliangruber You might want to rebase your clean up branches

@juliangruber
Copy link
Member

.json is one of the default file ending that nodejs tries when requiring a file without one, you can verify so be going to a module and disk and running this:

$ node -pe "require('./package')"

So I don't know what the issue in your build process really was, but if everything works like node or browserify - which this module targets as environments - it should work.

Did you maybe use something like webpack?

@PascalTemel
Copy link
Contributor Author

@juliangruber I'm sorry, apparently I missed the notification. levelup came as a dependency of pouchdb / worker-pouch. It's an angular2 project and our build process consists of NGC -> rollup -> closure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants