Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite buster tests as tape tests #674

Merged
merged 22 commits into from Sep 21, 2019
Merged

Rewrite buster tests as tape tests #674

merged 22 commits into from Sep 21, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Sep 15, 2019 •
edited

Closes #650. Closes #497. WIP. Has two goals:

  • Remove need for deprecated dependencies (referee, samsam)
  • Align test suite with abstract-leveldown's, so that they may be merged later on.

@vweevers vweevers added semver-patch Bug fixes that are backward compatible test Improvements or additions to tests labels Sep 15, 2019
@vweevers vweevers added this to In progress in Level (old board) via automation Sep 15, 2019
@vweevers vweevers mentioned this pull request Sep 19, 2019
Closed
@vweevers vweevers marked this pull request as ready for review September 19, 2019 18:12
@vweevers vweevers moved this from In progress to Review in Level (old board) Sep 19, 2019
@vweevers
Copy link
Member Author

Next up: #273, though for a different reason: to be able to call the test suite on an abstract-leveldown db. That will also require further refactoring of the tests, splitting them by features as well as separating "integration tests" (that don't operate on a testCommon.factory() db) from the test suite.

@vweevers vweevers mentioned this pull request Sep 20, 2019
Merged
ralphtheninja
ralphtheninja reviewed Sep 20, 2019
View reviewed changes
test/create-stream-vs-put-racecondition.js
;[true, false].forEach(function (encode) {
;[true, false].forEach(function (deferredOpen) {
;[true, false].forEach(function (delayedPut) {
makeTest(test, encode, deferredOpen, delayedPut)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

ralphtheninja
ralphtheninja reviewed Sep 20, 2019
View reviewed changes
Copy link
Member

@ralphtheninja ralphtheninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woha. Nice work! Not going through this in detail, just skimming it.

@vweevers
Copy link
Member Author

Not going through this in detail

I completely understand 😉

@vweevers
Copy link
Member Author

Because it's a lot, I'd like to keep the commits, not squash.

@vweevers vweevers merged commit 91ff0e7 into master Sep 21, 2019
Level (old board) automation moved this from Review to Done Sep 21, 2019
@vweevers vweevers deleted the rewrite-tests branch September 21, 2019 06:46
@vweevers vweevers mentioned this pull request Sep 21, 2019
Closed
@vweevers vweevers mentioned this pull request Sep 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja left review comments

Assignees
No one assigned
Labels
semver-patch Bug fixes that are backward compatible test Improvements or additions to tests
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite buster tests as tape tests Revive create-stream-vs-put-racecondition.js test
2 participants
@vweevers @ralphtheninja