Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade snappy to 1.1.7 #79

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Conversation

filoozom
Copy link
Contributor

@filoozom
Copy link
Contributor Author

Ping @ralphtheninja because of #78 (comment), sorry if that's not ok.

@vweevers vweevers added this to Backlog in Level (old board) via automation Oct 25, 2018
@vweevers vweevers moved this from Backlog to To Do in Level (old board) Oct 25, 2018
@peakji
Copy link
Member

peakji commented Oct 25, 2018

LGTM!

@ralphtheninja
Copy link
Member

wow, a tonne of code gone, nice

@ralphtheninja
Copy link
Member

@filoozom Btw recruitment time, would you like to be invited to the level org? 😄

@filoozom
Copy link
Contributor Author

filoozom commented Oct 25, 2018

@ralphtheninja Well, I might be working a tiny bit on upgrading the RocksDB dependency a bit, but probably won't have a ton of time to be very active. I guess it all depends on what you expect from your members. 😄

I also worked on a new Travis configuration file to prebuild musl versions of this library in addition to the glibc ones, and started working on ARM builds but I can't get them to cross build.

Is there something left to do on this PR to get it merged?

@ralphtheninja
Copy link
Member

@ralphtheninja Well, I might be working a tiny bit on upgrading the RocksDB dependency a bit, but probably won't have a ton of time to be very active. I guess it all depends on what you expect from your members.

That's totally fine. Most members aren't that active, so no pressure at all.

@filoozom
Copy link
Contributor Author

Well, count me in then!

@ralphtheninja
Copy link
Member

@filoozom We could use the help in updating snappy for leveldown as well.

@ralphtheninja
Copy link
Member

ralphtheninja commented Oct 25, 2018

@vweevers Patch or minor? I vote minor, just changed my mind to patch 😉

@filoozom
Copy link
Contributor Author

It's basically a bug fix for musl to be honest. Nothing changed, no feature added, no speed changes, a patch should be just fine. It was even a patch for snappy.

@vweevers
Copy link
Member

Does snappy follow semver?

@ralphtheninja ralphtheninja merged commit f53b445 into Level:master Oct 25, 2018
Level (old board) automation moved this from To Do to Done Oct 25, 2018
@vweevers
Copy link
Member

I vote minor, just changed my mind to patch 😉

Patch it is! I defer to your judgement on this :)

@ralphtheninja
Copy link
Member

3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants