Fix iterating buffer keys that contain bytes 196-255 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
commented
Feb 28, 2020
| if (Buffer.isBuffer(x) && !x.length) x = END | ||
| return concat(self.prefix, x || '\xff') | ||
| if (!x || isEmptyBuffer(x)) { | ||
| return self.prefix.slice(0, -1) + ceiling |
There was a problem hiding this comment.
An example: if the separator is ! then the "ceiling" is ". If you have a bunch of sublevels with prefixes ['!a!', '!a!!a!', '!aa!', '!b!'] and you want to get everything in !a!, then that's everything less than !a".
$ node
> ['!a!', '!a!!a!', '!aa!', '!b!', '!a"'].sort()
[ '!a!', '!a!!a!', '!a"', '!aa!', '!b!' ]
Is there a case where this doesn't work? Apart from a custom separator that leaves no room for the ceiling, like sub(db, '0', { separator: '/' }).
There was a problem hiding this comment.
this is a really good idea also for defining keys in general cases and get a range of it.
Previously (in any version) such keys were wrongly excluded by the range logic of subleveldown. The fix is not breaking for most folks. It's breaking if you: - Use the default separator and prefixes that contain '"' (byte 34) - Use a custom separator that doesn't sort 2 positions before characters used in your prefixes. For example with separator '/' (byte 47) prefixes must use characters greater than '0' (byte 48). In either case, an error will be thrown from the constructor.
vweevers
force-pushed
the
fix-buffer-keys
branch
from
123148e
to
dd82d61
Compare
vweevers
changed the title
vweevers
commented
Mar 8, 2020
vweevers
commented
Mar 8, 2020
|
5.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87. Previously (in any version) keys containing bytes 196-255 were wrongly excluded by the range logic of
subleveldown. The fix is not breaking for most folks.It's breaking if you:
"(byte 34)/(byte 47) prefixes must use characters greater than0(byte 48).In either case, an error will be thrown from the constructor.