Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use object shorthand for properties #91

Closed
wants to merge 1 commit into from

Conversation

LinusU
Copy link

@LinusU LinusU commented Apr 26, 2020

This rule is on its way into the latest Standard ☺️

ref: standard/eslint-config-standard#166

@vweevers
Copy link
Member

Which browsers support this syntax? That'll be a problem for many modules.

@LinusU
Copy link
Author

LinusU commented Apr 26, 2020

Sorry for not addressing this right away, I looked at the engines.node: >=6 and assumed that that was the only consideration.

As you commented in the other thread, this package should support the same browsers as memdown/levelup which includes Internet Explorer 11, a browser that doesn't support this syntax.

I will close this for now, and take it into consideration if we need to do some sort of conditionally applying of rules in Standard.

Thank you for bringing this up!

(also, would you like a PR that documents the supported browsers? ☺️)

@LinusU LinusU closed this Apr 26, 2020
@vweevers
Copy link
Member

also, would you like a PR that documents the supported browsers

Thanks for the offer ❤️ But there's a plan to add browser tests here, and then we'll document it. I prefer not to promise support of browsers X and Y unless we actively test it.

@LinusU
Copy link
Author

LinusU commented Apr 26, 2020

Sounds very smart 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants