Try to fix the zombie solver processes, don't hide the exceptions #695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is another attempt to fix the zombie solver processes mentioned in #477. Previously, a pull request has been sent as #691, and has been reverted in #693, as it introduced test failures where the error messages for the exceptions are hidden by a generic failure message, as discussed in #694.
The reason why that happened is that
finally
swallows the exception, and thequeryTerminate
being called in thefinally
clause throws the generic failure message.In addition to the fix in #691, this pull request tunes the
queryTerminate
function with an additionalMaybe SomeException
argument. The abnormal termination path will now pass the exceptions to thequeryTerminate
and let the function forward the exception.There are hard-coded paths for the solvers in the golden files, and the test suite requires all kinds of solvers to be installed, so I only ensured that
exceptionRemote1
, andexceptionLocal2
, andPlease run the full test suite in your environment to ensure that it works.