Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix the zombie solver processes, don't hide the exceptions #695

Merged
merged 1 commit into from May 11, 2024

Conversation

lsrcz
Copy link
Collaborator

@lsrcz lsrcz commented May 11, 2024

This pull request is another attempt to fix the zombie solver processes mentioned in #477. Previously, a pull request has been sent as #691, and has been reverted in #693, as it introduced test failures where the error messages for the exceptions are hidden by a generic failure message, as discussed in #694.

The reason why that happened is that finally swallows the exception, and the queryTerminate being called in the finally clause throws the generic failure message.

In addition to the fix in #691, this pull request tunes the queryTerminate function with an additional Maybe SomeException argument. The abnormal termination path will now pass the exceptions to the queryTerminate and let the function forward the exception.

There are hard-coded paths for the solvers in the golden files, and the test suite requires all kinds of solvers to be installed, so I only ensured that

  • this version passes exceptionRemote1, and
  • this version only differs by the path for exceptionLocal2, and
  • this version correctly kills the long-running or zombie processes.

Please run the full test suite in your environment to ensure that it works.

@lsrcz lsrcz mentioned this pull request May 11, 2024
@LeventErkok LeventErkok merged commit 0381599 into LeventErkok:master May 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants