-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for indexers and "callable" objects #132
Merged
mlasson
merged 10 commits into
LexiFi:master
from
cannorin:index-and-function-signature-binding
Feb 1, 2021
Merged
Add support for indexers and "callable" objects #132
mlasson
merged 10 commits into
LexiFi:master
from
cannorin:index-and-function-signature-binding
Feb 1, 2021
+363
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainfrisch
reviewed
Jan 30, 2021
alainfrisch
reviewed
Jan 30, 2021
mlasson
reviewed
Feb 1, 2021
mkfun | ||
(fun this -> | ||
match ty_args, ty_vararg, unit_arg with | ||
| [], None, false -> js2ml_unit [] ty_res (res this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you were not responsible for that; but this pattern matching was not making a lot of sense:
ty_vars, ty_avarg = [], None
implies formal_args = []
implies func formal_args false x = x
mlasson
force-pushed
the
index-and-function-signature-binding
branch
from
February 1, 2021 17:11
0ac7508
to
e6154ee
Compare
Nice PR thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three attributes for value binding:
[@@js.index_get]
,[@@js.index_set]
, and[@@js.apply]
.Indexers
[@@js.index_get]
and[@@js.index_set]
can be used to bind to indexer in a JS object. For example, the binding for getter and setter of JSBuffer
can now be written asinstead of
Function Objects
Sometimes a JS object can also be a function (so-called "callable object").
We can now bind this kind of object with the following:
Compatibility with TypeScript
This complements gen_js_api's ability to bind to TypeScript interfaces. With this PR merged, we now support Function Types and Indexable Types (which were very hard to bind).