Switch to js_of_ocaml.4.0 #164
Conversation
| (* The js_of_ocaml runtime expects to have this registered. | ||
| So it's probably a bad idea to use both this Ojs_exn module | ||
| and the js_of_ocaml standard library. *) | ||
| exception Error = Jsoo_runtime.Error.Exn |
There was a problem hiding this comment.
Is it the case that any code that used to catch Ojs_exn.Error will continue to work as before?
There was a problem hiding this comment.
Yes, as you can see, I haven't touched the interface. I'm just re-exporting the exception under a different name. The registration is done on the jsoo_runtime side and allow jsoo, gen_js_api and brr to coexist without interfering.
There was a problem hiding this comment.
We could also get rid of implements "externals" in the Ojs module with Jsoo_runtime... or maybe we could get rid of (or deprecate) the whole Ojs module and directly use Jsoo_runtime. But that may be another pull request.
I'm totally ok to merge this one as soon as possible and make an opam release just to quickly have a version of gen_js_api compatible with js_of_ocaml 4 on opam.
There was a problem hiding this comment.
@mlasson can you take care of merging this PR? Does anything need to be done for the CI to work?
There was a problem hiding this comment.
Hopefully, it will work when ocaml/opam-repository#20533 will be merged (the CI does not know yet how to fetch js_of_ocaml 4.0 with out a "pinning it").
|
I've removed the -no-check-prim usage as it should no longer be necessary. |
see ocaml/opam-repository#20533
and ocsigen/js_of_ocaml#1224