Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add js_of_ocaml support. #36

Merged
merged 5 commits into from
Apr 24, 2023
Merged

Add js_of_ocaml support. #36

merged 5 commits into from
Apr 24, 2023

Conversation

mefyl
Copy link
Contributor

@mefyl mefyl commented Apr 22, 2023

No description provided.

nojb
nojb reviewed Apr 22, 2023
View reviewed changes
src/clock.js Outdated Show resolved Hide resolved
nojb
nojb reviewed Apr 22, 2023
View reviewed changes
Copy link
Member

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Requires annotation needs fixing.

src/clock.js Outdated Show resolved Hide resolved
src/clock.js Outdated Show resolved Hide resolved
mefyl and others added 2 commits April 22, 2023 13:04
@mefyl @nojb
Update src/clock.js
6e467f4 
Co-authored-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
@mefyl @nojb
Update src/clock.js
e03f3be 
Co-authored-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
nojb
nojb approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a CHANGES.md entry? Thanks!

nojb
nojb approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nojb nojb merged commit b0c753c into LexiFi:master Apr 24, 2023
@nojb
Copy link
Member

nojb commented Apr 24, 2023

Thanks!

@mefyl mefyl deleted the js branch July 17, 2023 16:36
@WardBrian WardBrian mentioned this pull request Sep 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojb nojb nojb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mefyl @nojb @yberreby