Fixes for several exceptions #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Relay.potentialRelays list was being built just once, in the class's static constructor, with a subset of the Vessel objects (those with comms) that were available at that time. This was problematic for two reasons: first, it wouldn't notice changes that occur later (e.g. new vessels with comms being launched), and second, each entry to the flight scene seems to create a new set of Vessel objects, so the GetRelayVessel wouldn't find anything matching the new objects because the relays in the list would still hold references to the old ones. Rebuilding the potentialRelays list at each entry to the flight scene keeps it up-to-date with the current set of vessels and their Vessel objects.
Although the AHShipListListener calls ParseFlyingVessel when the player returns to the space center, that event fires while the vessel-recovery window is still open and before the recovered vessel has actually been removed from FlightGlobals.Vessels, so listFlyingVessel will include the recovered vessel in that case. If the player then goes to the tracking station, AHTrackingStation.CreateMarkers would throw exceptions trying to create a marker for it, since it wouldn't be found in FlightGlobals.Vessels anymore. Updating listFlyingVessel on entry to the tracking station avoids that.
This prevents KeyNotFoundExceptions every frame when the player selects something like an asteroid or EVA kerbal.
When leaving the scene, its GameObjects get destroyed, in no particular order. Sometimes it happens that an AHMapMarker's parent GameObject gets destroyed before the Vessel that the marker is associated with. Destroying the parent GameObject also destroys the AHMapMarker component, so if AHFlight.VesselDestroy later tries to access the component's gameObject property, it throws a NullReferenceException because the component is no longer associated with a GameObject. To avoid that, AHFlight now stores references to the actual GameObjects that it'll need to destroy later, instead of to the AHMapMarker components attached to them.
If the current vessel is a relay satellite, other vessels may have communication paths that go through it. If they do and the current vessel isn't in the potentialRelays list, GetRelayVessel returns null for it and LinkPath.SetLinks causes a NullReferenceException when it tries to construct a Link with a null relayB.
|
I've added one more fix: a NullReferenceException at entry to the flight scene if the active vessel is part of some other vessel's communication path, caused by the It's not entirely clear why the code that builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of fixes for several exceptions that I noticed while using AH:
Relay.potentialRelayslist having outdated information.AHShipList.listFlyingVesselhaving outdated information.AHMapMarkercomponents that have already been destroyed. (This one was only on the dev branch after the v1.0.4 release.)